feat(journal): add date support to API #7280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor to use a common `CreateEntry` service across the web and api
Refactor to use a common `UpdateEntry` service across web and api
Refactor to use a common `DestroyEntry` service across web and api
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add the ability to specify a date when creating a journal entry through the API, or more accurately require it. The functionality is there when using the web but it was missing from the API. The title is now also optional through the API to match the web functionality.
Additionally, I've also standardised creating, updating, and deleting of entries across the web and API controllers. This follows the pattern that is used for activities.
A migration was added that copies the date from the
journal_entries.dateinto the newly addedentries.datefield, which should be equivalent from what I understand.For more context, I'm a big fan of Monica and I found this missing functionality when trying to use the API to build an Android client. I've never worked with PHP or done web dev before but this was essential functionality for the app so thought I'd give this a shot 馃憖 Because of that please let me know if anything is missing or inconsistent!