Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a method compatible with mongoid-observers to determinine the version of mongoid. #126

Closed
wants to merge 1 commit into from

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Dec 9, 2014

Fixes #121, see #123.

@dblock dblock mentioned this pull request Dec 9, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) when pulling 7ab06f4 on dblock:fix-221 into 0c6aa47 on aq1018:master.

@dblock
Copy link
Collaborator Author

dblock commented Dec 9, 2014

This build fails in rbx because of a gem dependent of versionomy, see dazuma/blockenspiel#13.

@johnnyshields
Copy link
Member

👎 I don't think we need to introduce additional dependencies just to detect Mongoid version... can we use simple regex here?

@dblock
Copy link
Collaborator Author

dblock commented Dec 9, 2014

I think we can't, because this is just a can of worms when we hit version 5.0pre or some other weird thing like that. The point of checking for a class was to make it 100% reliable. Except of course when something else defines that class ;)

@johnnyshields
Copy link
Member

Mongoid::VERSION =~ /^3\./ will always match major version 3 (not 5.0.0pre, 13.x.x, etc)

@dblock
Copy link
Collaborator Author

dblock commented Dec 10, 2014

@johnnyshields I am down with whatever change, or none :)

@zeitnot
Copy link
Contributor

zeitnot commented Feb 9, 2015

ping @dblock

@dblock
Copy link
Collaborator Author

dblock commented Feb 9, 2015

Merged 8303884.

@dblock dblock closed this Feb 9, 2015
@zeitnot
Copy link
Contributor

zeitnot commented Feb 9, 2015

@dblock appreciated :)

@dblock
Copy link
Collaborator Author

dblock commented Feb 9, 2015

I released 0.4.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined local variable or method `metadata', incompatible with mongoid-observers
4 participants