SERVER-84667:index check, avoid create duplicate btree indexes, Avoid affecting performance #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y123456yz
changed the title
mongodt
reviewed
Jan 12, 2024
| //For example: | ||
| // Add two indexes: db.collection.createIndex({a:1}) and db.collection.createIndex({a:11}) | ||
| // The two indexes are actually the same, One of them is a useless index | ||
| auto dealIndexKeyPattern = [&](const BSONObj& indexKeyPattern) { |
There was a problem hiding this comment.
Please capture what is needed, in this case "this". Change [&] to [this].
A better name for dealIndexKeyPattern is canonizeIndexKeyPattern.
|
@mongodt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
btree index check, avoid create duplicate btree indexes, Avoid affecting performance
btree index check, avoid create duplicate btree indexes, Avoid affecting performance by the deplicate index.
for example:
add two index: db.collection.createIndex({a:1}) and db.collection.createIndex({a:11})
the tow index are actually the same, One of them is a useless index, but it can affect the insert performance.
In addition, They also affecting query performance because both are candidate indexes. This increases storage consts.