CSOT #1215

katcharov · 2023-10-04T22:25:38Z

Initial client side operation timeout (CSOT) work. The CSOT class is passed to all operations and currently encapsulate the following timeouts: - `timeoutMS` the new optional client side operation timeout - `maxTimeMS` the legacy maxTimeMS operation value. Ignored if CSOT is set. - `maxCommitTimeMS` the legacy commit timeout. Ignored if CSOT is set. - `maxAwaitTimeMS` the getMore await timeout. This initial work allows for the CSOT to be available to all operations and later work will pass / apply this timeout where required by the Spec. JAVA-4086

JAVA-4064

# Conflicts: # driver-core/src/main/com/mongodb/ConnectionString.java # driver-core/src/test/unit/com/mongodb/MongoClientSettingsSpecification.groovy

…terface (#1194) JAVA-5112

An immutable class that contains all user configured timeouts. This will eventaually allow access to user configuration down the stack into Bindings / Cluster.selectServer and Connection.command. JAVA-5169

JAVA-5175

In preparation for adding all contexts to OperationContext JAVA-5170

This will allow the timeout settings to be available to the Binding and this will allow the binding to create the TimeoutContext for the operation. JAVA-5170

Now contains RequestContext, SessionContext and TimeoutContext JAVA-5170

JAVA-5170

Operations now supply TimeoutSettings JAVA-5170

Pass OperationContext as a whole instead of RequestContext, SessionContext, TimeoutContext and ServerAPI JAVA-5170

Adds support for Explainable operations JAVA-5172

JAVA-5170

# Conflicts: # driver-core/src/main/com/mongodb/internal/connection/BaseCluster.java # driver-core/src/main/com/mongodb/internal/connection/LoadBalancedCluster.java # driver-core/src/test/functional/com/mongodb/ClusterFixture.java # driver-core/src/test/unit/com/mongodb/internal/connection/BaseClusterSpecification.groovy # driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/ClientSessionBinding.java # driver-reactive-streams/src/test/unit/com/mongodb/reactivestreams/client/internal/ClientSessionBindingSpecification.groovy # driver-sync/src/test/unit/com/mongodb/client/internal/ClientSessionBindingSpecification.groovy

…#1209) JAVA-5184

katcharov · 2023-10-20T14:10:19Z

driver-core/src/main/com/mongodb/internal/time/Timeout.java

-        if (this == o) {
-            return true;
+    static Timeout expiresIn(final long duration, final TimeUnit unit) {
+        // TODO (CSOT) confirm that all usages in final PR are non-negative


Note to address all TODOs prior to merging. (All files in github can be loaded using document.querySelectorAll('.load-diff-button').forEach(node => node.click()) in console, and then ctrl-f for TODO)

JAVA-5212

katcharov · 2024-03-28T20:26:02Z

driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/MongoCollection.java

+     * @since CSOT
+     * @see #getTimeout
+     */
+    MongoCollection<TDocument> withTimeout(long timeout, TimeUnit timeUnit);


See #1349 (comment) - clarify regarding use of times below 1ms.

katcharov · 2024-04-02T19:56:30Z

driver-core/src/main/com/mongodb/internal/TimeoutContext.java

+    public void resetTimeout() {
+        assertNotNull(timeout);
+        timeout = calculateTimeout(timeoutSettings.getTimeoutMS());
+    }


Consider changing to resetTimeoutIfPresent, with an if check on null rather than the assert. All prod usages perform this check before calling.

Also prevent NPE leak from TlsChannelImpl Also added temp fix for timeoutRemainingMS (scheduled to be removed) JAVA-5401 Added temp fix for timeoutRemainingMS which will eventually be removed

Added createOptions support for collection creation Fixed error with awaitable tailable cursors Manually change tests to use defaultTimeoutMS for the session as there is no operation overrdie Disable test JAVA-5406 - ClientSideEncryptionTest timeoutMS.json JAVA-5374

JAVA-5376

Add CSOT error transformation. JAVA-5248 Co-authored-by: Ross Lawley <ross@mongodb.com>

JAVA-5384

JAVA-4062

JAVA-5403

- Resolve regression where CSOT exception is exposed despite CSOT being disabled. - Correct premature decrease in connect timeout before connection initiation. - Encapsulate logic within TimeoutContext. JAVA-5439

…1376) JAVA-5425

JAVA-5402 Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

JAVA-5451

JAVA-5473

Co-authored-by: Valentin Kovalenko <valentin.kovalenko@mongodb.com> Co-authored-by: Maxim Katcharov <maxim.katcharov@mongodb.com> Co-authored-by: Jeff Yemin <jeff.yemin@mongodb.com> Co-authored-by: ashni <105304831+ashni-mongodb@users.noreply.github.com>

# Conflicts: # THIRD-PARTY-NOTICES # config/spotbugs/exclude.xml # driver-core/src/main/com/mongodb/internal/connection/Authenticator.java # driver-core/src/main/com/mongodb/internal/connection/DefaultAuthenticator.java # driver-core/src/main/com/mongodb/internal/connection/InternalConnection.java # driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java # driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnectionInitializer.java # driver-core/src/main/com/mongodb/internal/connection/OidcAuthenticator.java # driver-core/src/main/com/mongodb/internal/connection/SaslAuthenticator.java # driver-core/src/test/functional/com/mongodb/ClusterFixture.java # driver-core/src/test/unit/com/mongodb/internal/connection/AbstractConnectionPoolTest.java # driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/syncadapter/SyncMongoClient.java # driver-sync/src/test/functional/com/mongodb/client/csot/ClientSideOperationsEncryptionTimeoutProseTest.java # driver-sync/src/test/functional/com/mongodb/client/unified/Entities.java

evergreen-ci-prod · 2024-06-11T16:13:02Z

There is an existing patch(es) for this commit SHA:

Evergreen patch with PR

Please note that the status that is posted is not in the context of this PR but rather the (latest) existing patch and that may affect some tests that may depend on the particular PR. If your tests do not rely on any PR-specific values (like base or head branch name) then your tests will report the same status. If you would like a patch to run in the context of this PR and abort the other(s), comment 'evergreen retry'.

# Conflicts: # driver-sync/src/main/com/mongodb/client/gridfs/GridFSDownloadStreamImpl.java # driver-sync/src/main/com/mongodb/client/gridfs/GridFSUploadStreamImpl.java

- Mark session as dirty when MongoSocketException occurs. - Skip killCursors command execution when getMore fails in LOAD_BALANCER mode. JAVA-5474 JAVA-5476

JAVA-5340

- Re-enable tests that were previously disabled. - Add additional assertions to enhance test reliability. - Implement ignoreExtraEvents override to address flakiness in tests with race conditions. - Fix issue where timeoutContext is null in subsequent commit transactions. - Reduce timeouts in serverless tests to ensure they pass. JAVA-5104

rozza and others added 28 commits August 22, 2023 14:43

CSOT: Added timeout to settings & connection string (#1173)

83eeb10

JAVA-4064

Merge remote-tracking branch 'upstream/master' into CSOT

087973e

# Conflicts: # driver-core/src/main/com/mongodb/ConnectionString.java # driver-core/src/test/unit/com/mongodb/MongoClientSettingsSpecification.groovy

Replace Timeout implementation with interface, introduce StartTime in…

8f710f3

…terface (#1194) JAVA-5112

Added TimeoutSettings

432bcb0

An immutable class that contains all user configured timeouts. This will eventaually allow access to user configuration down the stack into Bindings / Cluster.selectServer and Connection.command. JAVA-5169

Refactor to use Timeout for server selection (#1202)

158b69c

JAVA-5175

Checkstyle fix

4b92ec6

Renamed ClientSideOperationTimeout to TimeoutContext

7334f5e

In preparation for adding all contexts to OperationContext JAVA-5170

Added getTimeoutSettings to Operation interfaces

10beb22

This will allow the timeout settings to be available to the Binding and this will allow the binding to create the TimeoutContext for the operation. JAVA-5170

OperationContext promotion

aee66e4

Now contains RequestContext, SessionContext and TimeoutContext JAVA-5170

Cluster Binding now creates the OperationContext

bcdc0eb

JAVA-5170

BindingContext now only contains OperationContext

46f5eba

Operations now supply TimeoutSettings JAVA-5170

Propogate Operation Context

87b7843

Pass OperationContext as a whole instead of RequestContext, SessionContext, TimeoutContext and ServerAPI JAVA-5170

CommandProtocol is now immutable

511a3c3

Add CommandCreator support to CommandReadOperation

0ecc3f5

Adds support for Explainable operations JAVA-5172

Update Tests regarding OperationContext

767bb1c

JAVA-5170

Merge branch 'master' into CSOT-merge

1e769b0

Merge branch 'master' into CSOT

c4ccc24

Merge branch 'master' into CSOT

bdc2abb

Merge branch 'master' into CSOT

c442689

Merge branch 'master' into CSOT

2a0707d

Fix codenarc

35d82be

Spotbugs fixes / exclusions

a9a3b2d

Refactor to obtain timeout from OperationContext for server selection (…

4b002c0

…#1209) JAVA-5184

Fix minor test failure, checkstyle

d65d27f

Merge branch 'master' into CSOT

e8bdab5

Update BindingContext Javadoc

a881808

katcharov commented Oct 20, 2023

View reviewed changes

Obtain waitQueue and connection timeouts from OperationContext (#1228)

ea6c37c

JAVA-5212

katcharov commented Mar 28, 2024

View reviewed changes

katcharov commented Apr 2, 2024

View reviewed changes

rozza and others added 21 commits April 3, 2024 13:40

Merge branch 'master' into CSOT

233f524

Improve debugging of dropped onError when tests fail

6d625e0

Fix newline in debugging onError dropped

24bf543

Merge branch 'master' into CSOT

8a320c2

Merge branch 'master' into CSOT

b169c3a

Ensure encryption timeouts are enough for testing against

4e97f21

Also prevent NPE leak from TlsChannelImpl Also added temp fix for timeoutRemainingMS (scheduled to be removed) JAVA-5401 Added temp fix for timeoutRemainingMS which will eventually be removed

Replace Timeout methods with branching "run" methods (#1349)

3b6ba32

JAVA-5376

CSOT error transformation (#1360)

98c5bd4

Add CSOT error transformation. JAVA-5248 Co-authored-by: Ross Lawley <ross@mongodb.com>

Override collection/database with infinite timeout. (#1350)

235adf4

JAVA-5384

Ignore wTimeoutMS in WriteConcern when timeoutMS is set (#1368)

4a15e31

JAVA-4062

Undeprecate timeout APIs (#1369)

ffc21e6

JAVA-5403

Merge branch 'master' into CSOT

997e92f

Fix regression in timeout handling. (#1373)

b02a5f9

- Resolve regression where CSOT exception is exposed despite CSOT being disabled. - Correct premature decrease in connect timeout before connection initiation. - Encapsulate logic within TimeoutContext. JAVA-5439

Ensure TimeoutContext is present for a subsequent commit operation. (#…

dca0278

…1376) JAVA-5425

Mark CSOT feature as Alpha (#1372)

2fdae3b

JAVA-5402 Co-authored-by: Valentin Kovalenko <valentin.male.kovalenko@gmail.com>

Fix race condition in retry logic. (#1377)

1f30837

JAVA-5451

Remove RTT check before reading a response from the server. (#1391)

0d2d8e8

JAVA-5473

Merge branch 'refs/heads/master' into CSOT

d0941fc

vbabanin added 6 commits June 11, 2024 09:17

Merge branch 'refs/heads/master' into CSOT

b4b2e88

# Conflicts: # driver-sync/src/main/com/mongodb/client/gridfs/GridFSDownloadStreamImpl.java # driver-sync/src/main/com/mongodb/client/gridfs/GridFSUploadStreamImpl.java

Fix merge issues.

b1971b7

CSOT: Network failure handling and session management (#1396)

b40be6b

- Mark session as dirty when MongoSocketException occurs. - Skip killCursors command execution when getMore fails in LOAD_BALANCER mode. JAVA-5474 JAVA-5476

Remove extra expected event in tests. (#1363)

e8eb097

JAVA-5340

Merge branch 'master' into CSOT

be5a60d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CSOT #1215

CSOT #1215

katcharov commented Oct 4, 2023

katcharov Oct 20, 2023

katcharov Mar 28, 2024

katcharov Apr 2, 2024

evergreen-ci-prod bot commented Jun 11, 2024

CSOT #1215

Are you sure you want to change the base?

CSOT #1215

Conversation

katcharov commented Oct 4, 2023

katcharov Oct 20, 2023

Choose a reason for hiding this comment

katcharov Mar 28, 2024

Choose a reason for hiding this comment

katcharov Apr 2, 2024

Choose a reason for hiding this comment

evergreen-ci-prod bot commented Jun 11, 2024