CSHARP-3986: Fix flaky ConnectionPool_cleared_on_failed_hello test #1326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BorisDog
reviewed
May 21, 2024
| @@ -116,6 +116,32 @@ public object Next() | |||
| } | |||
| } | |||
|
|
|||
| public int RemoveWhile(Func<object,bool> predicate) | |||
There was a problem hiding this comment.
btw, we can start using IEvent in such APIs (and then check IEvent.Type == EventType.MyEvent)
Also consider if just using SkipWhile is sufficient:
For example
var events = eventCapturer.Events
.OfType<IEvent>()
.SkipWhile(e => e.Type == EventType.ServerHeartbeatSucceeded);
events.ElementAt(0).Should().BeOfType<ServerHeartbeatFailedEvent>();
events.ElementAt(1).Should().BeOfType<ServerHeartbeatSucceededEvent>();
events = events.SkipWhile(e => e.Type == EventType.ServerHeartbeatSucceeded);
events.ElementAt(0).Should().BeOfType<ServerHeartbeatSucceededEvent>();
events.ElementAt(1).Should().BeOfType<ConnectionPoolReadyEvent>();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.