Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Correct typo in types.ipynb #2646

Closed
wants to merge 1 commit into from

Conversation

avi-cenna
Copy link

Correcting typo.

Copy link
Collaborator

@arthurevans arthurevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@arthurevans
Copy link
Collaborator

Do you mind targeting the nightly branch? Please see the contributing docs.

@avi-cenna avi-cenna changed the base branch from main to nightly May 14, 2024 13:55
@avi-cenna avi-cenna requested review from jackos and a team as code owners May 14, 2024 13:55
@avi-cenna avi-cenna changed the base branch from nightly to main May 14, 2024 13:55
Correct typo

Signed-off-by: N <47500890+avi-cenna@users.noreply.github.com>
@avi-cenna avi-cenna changed the base branch from main to nightly May 14, 2024 14:09
@avi-cenna avi-cenna changed the title Correct typo in types.ipynb [docs] Correct typo in types.ipynb May 14, 2024
@avi-cenna
Copy link
Author

@arthurevans Sure, I have updated.

@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label May 14, 2024
modularbot pushed a commit that referenced this pull request May 15, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes #2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a
@modularbot modularbot added the merged-externally Merged externally in public mojo repo label May 15, 2024
@modularbot
Copy link
Collaborator

Landed in 2d015fb! Thank you for your contribution 🎉

@modularbot modularbot closed this May 15, 2024
rd4com pushed a commit to rd4com/mojo_branch that referenced this pull request May 15, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes modularml#2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a

Signed-off-by: rd4com <144297616+rd4com@users.noreply.github.com>
msaelices pushed a commit to msaelices/mojo that referenced this pull request May 15, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes modularml#2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a
lsh pushed a commit to lsh/mojo that referenced this pull request May 17, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes modularml#2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a

Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
msaelices pushed a commit to msaelices/mojo that referenced this pull request May 18, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes modularml#2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a
martinvuyk pushed a commit to martinvuyk/mojo that referenced this pull request May 24, 2024
[External] [docs] Correct typo in types.ipynb

Correcting typo.

Co-authored-by: N <47500890+avi-cenna@users.noreply.github.com>
Closes modularml#2646
MODULAR_ORIG_COMMIT_REV_ID: aef3bb9dca96efdc6badc7b9369f14583ea2c71a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants