[stdlib] Implement List.__repr__() method #2634
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_() one Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
msaelices
changed the title
stdlib/src/collections/list.mojo
Outdated
| @@ -72,7 +72,9 @@ struct _ListIter[ | |||
| return self.index | |||
|
|
|||
|
|
|||
| struct List[T: CollectionElement](CollectionElement, Sized, Boolable): | |||
| struct List[T: CollectionElement]( | |||
| CollectionElement, Sized, Boolable, Representable | |||
There was a problem hiding this comment.
The list cannot be Representable yet because __repr__ is a staticmethod and not a method. We need conditional conformance to make List Representable conditionally. I think you can remove it.
| @@ -31,6 +31,12 @@ fn test_variadic_list() raises: | |||
| check_list(5, 8, 6) | |||
|
|
|||
|
|
|||
| fn test_repr_list() raises: | |||
There was a problem hiding this comment.
Can you also add a test case for an empty List? That would ensure the code doesn't break in the future.
…method yet Signed-off-by: Manuel Saelices <msaelices@gmail.com>
Signed-off-by: Manuel Saelices <msaelices@gmail.com>
gabrieldemarmiesse
approved these changes
May 14, 2024
JoeLoser
approved these changes
May 16, 2024
There was a problem hiding this comment.
Looks good, thank you! We have a trick proven out today for the List.index() method that I think we can apply here as well when the new nightly is available later tonight/tomorrow. I'll merge this internally in the meantime and we can refactor it as a static method to avoid the __type_of dance.
JoeLoser
added
the
imported-internally
|
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
modularbot
added
the
merged-internally
modularbot
pushed a commit
that referenced
this pull request
May 16, 2024
[External] [stdlib] Implement List.__repr__() method Based on the `List.__str__()` one, to allow to call `repr(some_list)`. It's not currently passing because of the following error, but I think the code is correct and it's a limitation of the mojo compiler, which does not understand that, if `self` is made of `RepresentableCollectionElement`, the `__repr__` method can call the `__str__` one, as `__type_of(self)` will also be `List[RepresentableCollectionElement]`  Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes #2634 MODULAR_ORIG_COMMIT_REV_ID: b939d766211d3666fe65eea198f4bf24e734a180
|
Landed in ba59164! Thank you for your contribution 🎉 |
lsh
pushed a commit
to lsh/mojo
that referenced
this pull request
May 17, 2024
[External] [stdlib] Implement List.__repr__() method Based on the `List.__str__()` one, to allow to call `repr(some_list)`. It's not currently passing because of the following error, but I think the code is correct and it's a limitation of the mojo compiler, which does not understand that, if `self` is made of `RepresentableCollectionElement`, the `__repr__` method can call the `__str__` one, as `__type_of(self)` will also be `List[RepresentableCollectionElement]`  Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2634 MODULAR_ORIG_COMMIT_REV_ID: b939d766211d3666fe65eea198f4bf24e734a180 Signed-off-by: Lukas Hermann <lukashermann28@gmail.com>
msaelices
added a commit
to msaelices/mojo
that referenced
this pull request
May 18, 2024
[External] [stdlib] Implement List.__repr__() method Based on the `List.__str__()` one, to allow to call `repr(some_list)`. It's not currently passing because of the following error, but I think the code is correct and it's a limitation of the mojo compiler, which does not understand that, if `self` is made of `RepresentableCollectionElement`, the `__repr__` method can call the `__str__` one, as `__type_of(self)` will also be `List[RepresentableCollectionElement]`  Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2634 MODULAR_ORIG_COMMIT_REV_ID: b939d766211d3666fe65eea198f4bf24e734a180
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Implement List.__repr__() method Based on the `List.__str__()` one, to allow to call `repr(some_list)`. It's not currently passing because of the following error, but I think the code is correct and it's a limitation of the mojo compiler, which does not understand that, if `self` is made of `RepresentableCollectionElement`, the `__repr__` method can call the `__str__` one, as `__type_of(self)` will also be `List[RepresentableCollectionElement]`  Co-authored-by: Manuel Saelices <msaelices@gmail.com> Closes modularml#2634 MODULAR_ORIG_COMMIT_REV_ID: b939d766211d3666fe65eea198f4bf24e734a180
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the
List.__str__()one, to allow to callrepr(some_list).It's not currently passing because of the following error, but I think the code is correct and it's a limitation of the mojo compiler, which does not understand that, if
selfis made ofRepresentableCollectionElement, the__repr__method can call the__str__one, as__type_of(self)will also beList[RepresentableCollectionElement]