[stdlib] Implement SSO using small buffer optimization on List
#2632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
1 task
mzaks
reviewed
May 24, 2024
| return getenv(name, "") | ||
|
|
||
|
|
||
| fn getenv(name: String, default: String) -> String: |
There was a problem hiding this comment.
Should we change the signature to fn getenv(name: String, default: String = "") -> String and avoid introducing fn getenv(name: String) -> String?
There was a problem hiding this comment.
I cannot use default values because of this bug :( #2637
When this is solved, I'll be able to remove those diffs
mzaks
reviewed
May 24, 2024
| return listdir("") | ||
|
|
||
|
|
||
| fn listdir(path: String) raises -> List[String]: |
There was a problem hiding this comment.
Should we change the signature to fn listdir(path: String) raises -> List[String] and avoid introducing fn listdir() raises -> List[String]?
mzaks
reviewed
May 24, 2024
|
|
||
|
|
||
| @always_inline | ||
| fn assert_true(val: Bool, msg: String) raises: |
There was a problem hiding this comment.
Also here, rather msg: String = "condition was unexpectedly False"?
mzaks
reviewed
May 24, 2024
|
|
||
|
|
||
| @always_inline | ||
| fn assert_false(val: Bool, msg: String) raises: |
There was a problem hiding this comment.
same here: msg: String = "condition was unexpectedly True"
mzaks
reviewed
May 24, 2024
|
|
||
|
|
||
| @always_inline | ||
| fn assert_equal[T: Testable](lhs: T, rhs: T, msg: String) raises: |
|
Closing in favor of #2827 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2613
We still have the materialization issue. Thus we need to remove all materialization of
String. All other tests are passing in the stdlib.This is related to #2467 . Do not merge yet