Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] correct output, fix indent in Heterogeneous variadic arguments #2631

Closed
wants to merge 1 commit into from

Conversation

kengz
Copy link

@kengz kengz commented May 12, 2024

The current Heterogeneous variadic arguments (see screenshot) - last example has wrong output (Bob0 should be Bob), and indentation of the example code is also off (had to edit after copying into Mojo playground)

Screenshot 2024-05-12 at 9 31 51 AM

Signed-off-by: Wah Loon Keng <kengzwl@gmail.com>
@kengz kengz changed the title correct output, fix indent in Heterogeneous variadic arguments [Docs] correct output, fix indent in Heterogeneous variadic arguments May 12, 2024
@JoeLoser
Copy link
Collaborator

Hi there, do you mind targeting the nightly branch? Please see the contributing docs.

@JoeLoser JoeLoser requested a review from a team May 13, 2024 23:53
@kengz kengz changed the base branch from main to nightly May 18, 2024 17:00
@kengz kengz requested review from jackos and a team as code owners May 18, 2024 17:00
@kengz kengz changed the base branch from nightly to main May 18, 2024 17:01
@kengz
Copy link
Author

kengz commented May 18, 2024

upstream nightly too different from master, rebase has huge diff. reopening PR with cherry-pick on nightly branch

@kengz kengz closed this May 18, 2024
@kengz kengz deleted the patch-1 branch May 18, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants