-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] implement os.path.getsize #2626
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLoser
approved these changes
May 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for working on this! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.
artemiogr97
force-pushed
the
os_path_getsize
branch
from
May 18, 2024 14:38
809e334
to
0e22430
Compare
@JoeLoser I just modified the changelog |
artemiogr97
force-pushed
the
os_path_getsize
branch
from
May 18, 2024 14:40
0e22430
to
f870698
Compare
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
!sync |
JoeLoser
added
the
imported-internally
Signals that a given pull request has been imported internally.
label
May 20, 2024
Landed in e0f68ac! Thank you for your contribution 🎉 |
modularbot
added a commit
that referenced
this pull request
May 21, 2024
[External] [stdlib] Implement `os.path.getsize` Add `getsize` method for getting the size (in bytes) of a path. Fixes #1130 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=#2626 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes #2626 MODULAR_ORIG_COMMIT_REV_ID: 443260f3be31a694c9e93fc11b64d0317646c4e0
martinvuyk
pushed a commit
to martinvuyk/mojo
that referenced
this pull request
May 24, 2024
[External] [stdlib] Implement `os.path.getsize` Add `getsize` method for getting the size (in bytes) of a path. Fixes modularml#1130 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2626 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes modularml#2626 MODULAR_ORIG_COMMIT_REV_ID: 443260f3be31a694c9e93fc11b64d0317646c4e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
imported-internally
Signals that a given pull request has been imported internally.
merged-externally
Merged externally in public mojo repo
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation for #1130