-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] implement fromkeys in Dict #2622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I wonder if we can optimize this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you for working on this! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.
2578747
to
981495a
Compare
981495a
to
f4a850f
Compare
Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
!sync |
✅🟣 This contribution has been merged 🟣✅ Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours. We use Copybara to merge external contributions, click here to learn more. |
Landed in e8f8662! Thank you for your contribution 🎉 |
[External] [stdlib] implement fromkeys in Dict Add `fromkeys()` method to `Dict` which returns a `Dict` with the specified keys and value. Fixes #2546 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=#2622 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes #2622 MODULAR_ORIG_COMMIT_REV_ID: 4f43dc59a68509d8ae781215e0f0956e560fa38e
[External] [stdlib] implement fromkeys in Dict Add `fromkeys()` method to `Dict` which returns a `Dict` with the specified keys and value. Fixes modularml#2546 ORIGINAL_AUTHOR=artemiogr97 <57588855+artemiogr97@users.noreply.github.com> PUBLIC_PR_LINK=modularml#2622 Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com> Closes modularml#2622 MODULAR_ORIG_COMMIT_REV_ID: 4f43dc59a68509d8ae781215e0f0956e560fa38e
Implementation for: #2546