Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] implement fromkeys in Dict #2622

Closed
wants to merge 1 commit into from

Conversation

artemiogr97
Copy link
Contributor

Implementation for: #2546

@artemiogr97 artemiogr97 requested a review from a team as a code owner May 11, 2024 18:11
Copy link
Contributor

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I wonder if we can optimize this

stdlib/src/collections/dict.mojo Show resolved Hide resolved
@artemiogr97 artemiogr97 changed the title [stdlib] implement fromdict in Dict [stdlib] implement fromkeys in Dict May 14, 2024
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for working on this! Do you mind adding a changelog entry here please? Happy to import it and land this internally after that.

Signed-off-by: Artemio Garza Reyna <artemiogr97@gmail.com>
@JoeLoser
Copy link
Collaborator

!sync

@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label May 21, 2024
@modularbot
Copy link
Collaborator

Landed in e8f8662! Thank you for your contribution 🎉

@modularbot modularbot added the merged-externally Merged externally in public mojo repo label May 21, 2024
modularbot added a commit that referenced this pull request May 21, 2024
[External] [stdlib] implement fromkeys in Dict

Add `fromkeys()` method to `Dict` which returns a `Dict`
with the specified keys and value.

Fixes #2546

ORIGINAL_AUTHOR=artemiogr97
<57588855+artemiogr97@users.noreply.github.com>
PUBLIC_PR_LINK=#2622

Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com>
Closes #2622
MODULAR_ORIG_COMMIT_REV_ID: 4f43dc59a68509d8ae781215e0f0956e560fa38e
@modularbot modularbot closed this May 21, 2024
martinvuyk pushed a commit to martinvuyk/mojo that referenced this pull request May 24, 2024
[External] [stdlib] implement fromkeys in Dict

Add `fromkeys()` method to `Dict` which returns a `Dict`
with the specified keys and value.

Fixes modularml#2546

ORIGINAL_AUTHOR=artemiogr97
<57588855+artemiogr97@users.noreply.github.com>
PUBLIC_PR_LINK=modularml#2622

Co-authored-by: artemiogr97 <57588855+artemiogr97@users.noreply.github.com>
Closes modularml#2622
MODULAR_ORIG_COMMIT_REV_ID: 4f43dc59a68509d8ae781215e0f0956e560fa38e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants