[stdlib] Use UInt8 to store characters in String
#2612
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <gabrieldemarmiesse@gmail.com>
JoeLoser
added
the
imported-internally
|
Happy to see that 4433f95 was merged! I think we can close this PR now |
Yep, thanks for closing this out. As I mentioned at #2509 (comment), a lot of this stuff was intertwined internally, so it was easier for @rparolin to just make a bigger commit to knock it all out. Thanks for pushing on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fact that there are so many changes to do means that many functions access
String's internal buffer without going through the method provided (for exampleunsafe_ptr()). It might be worth it to rework a bit the API so that when we change theString's internals later on, we don't have to touch too many things. I'm notably thinking here about SSO and Unicode.This PR is part of #2317
Thanks god ASCII chars are between 0 and 127...