Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mojo-stdlib] Removed constructor from Stringable #2579

Conversation

Signed-off-by: Kaushal Phulgirkar <kaushalpp01@gmail.com>
@StandinKP StandinKP force-pushed the removed_constructor_from_stringable branch from 3be5736 to d0167a3 Compare May 10, 2024 04:38
@StandinKP
Copy link
Author

@JoeLoser is this also merged?

@JoeLoser
Copy link
Collaborator

@JoeLoser is this also merged?

This has not been merged yet internally. The PR here will auto close when it is. I fixed 50 or so occurrences yesterday, but we still have a ton more internally to fix before we can remove this constructor. I may mark it as deprecated to motivate folks internally to update their code so I'm not in the business of fixing the whole codebase for every stdlib change :)

@JoeLoser JoeLoser added the blocked Blocked by another issue that must be resolved first label May 20, 2024
@JoeLoser
Copy link
Collaborator

@Dan13llljws just fixed the rest of the internal sites to land this work. Thank you, everyone!

@JoeLoser JoeLoser closed this May 29, 2024
@JoeLoser JoeLoser removed the blocked Blocked by another issue that must be resolved first label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants