Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#7233: Display property name in default_to_pandas error messages #7269

Merged
merged 1 commit into from
May 15, 2024

Conversation

noloerino
Copy link
Collaborator

What do these changes do?

Fixes the retrieval of the name field of property objects in DefaultMethod.register. It previously displayed a hex address for the property, and now instead displays the name of its fget method.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Properties that default to pandas have unclear error messages #7233
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

…ror messages

Signed-off-by: Jonathan Shi <jhshi07@gmail.com>
@YarShev YarShev merged commit 12f6a3c into modin-project:main May 15, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properties that default to pandas have unclear error messages
2 participants