Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volume for playing sounds #685

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add volume for playing sounds #685

wants to merge 2 commits into from

Conversation

bruh-9000
Copy link
Contributor

No description provided.

@bruh-9000 bruh-9000 mentioned this pull request Dec 21, 2023
Open
@bruh-9000 @steffkes
Update src/gameClasses/ClientNetworkEvents.js
97b76d0 
by @steffkes

Co-authored-by: Stefan <steffkes@users.noreply.github.com>
@m0dE
Copy link
Contributor

m0dE commented Feb 22, 2024

image bug.

are you sure this has been tested?

@bruh-9000
Copy link
Contributor Author

I remember testing this and it worked fine

@minotalen
Copy link
Contributor

Please provide a JSON example that:

  • plays sound at regular volume (default, old action)
  • plays sound at random volume (new action)
    This is a useful addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffkes steffkes steffkes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bruh-9000 @m0dE @minotalen @steffkes