Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapier #1036

Draft
wants to merge 50 commits into
base: master
Choose a base branch
from
Draft

Rapier #1036

wants to merge 50 commits into from

Conversation

sloont
Copy link
Contributor

@sloont sloont commented May 10, 2024

No description provided.

.gitignore Outdated
@@ -128,6 +128,10 @@ engine/components/physics/box2d/distsWrapper/*.js
engine/components/physics/box2d/distsWrapper/*.js.map
engine/components/physics/box2d/dists.js
engine/components/physics/box2d/dists.js.map
engine/components/physicsPhysicsComponent.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a slash (/)?

@@ -9,6 +9,9 @@ var TaroEntityPhysics = TaroEntity.extend({
var self = this;

this._b2dRef = taro.physics;
if (this.physics.engine === 'RAPIER') {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Old example code I believe, can be removed.

src/client.js Outdated
@@ -665,6 +665,7 @@ const Client = TaroEventingClass.extend({

if (gravity) {
taro.physics.gravity(gravity.x, gravity.y);
console.log(taro.physics.gravity);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@@ -21,6 +21,7 @@ var MapComponent = TaroEntity.extend({
$.when(taro.client.taroEngineStarted).done(function () {
taro.addComponent(TaroTiledComponent).tiled.loadJson(data, function (TaroLayerArray, TaroLayersById) {
if (taro.physics && TaroLayersById.walls) {
console.log(TaroLayersById.walls);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants