-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c8d: Add ImageConvert #47678
Draft
vvoland
wants to merge
6
commits into
moby:master
Choose a base branch
from
vvoland:c8d-multiplatform-convert
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
c8d: Add ImageConvert #47678
+521
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
added
area/images
containerd-integration
Issues and PRs related to containerd integration
area/ux
labels
Apr 4, 2024
This was referenced Apr 4, 2024
vvoland
force-pushed
the
c8d-multiplatform-convert
branch
from
April 4, 2024 15:33
442ddb2
to
e9de94f
Compare
vvoland
commented
Apr 4, 2024
Comment on lines
538
to
548
dst, err := reference.ParseNamed(r.Form.Get("to")) | ||
if err != nil { | ||
return errdefs.InvalidParameter(fmt.Errorf("invalid 'to' parameter: %w", err)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also accept multiple tags.
vvoland
force-pushed
the
c8d-multiplatform-convert
branch
4 times, most recently
from
May 20, 2024 15:48
76a027b
to
a096594
Compare
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Introduce a new `ImageConvert` operation to the image service (only supported by the containerd image store) to convert multi-platform image indexes. The intent behind adding a new operation is to make the reduction of a multi-platform image to a single-platform image explicit to the user and not force operation like push to create a new image index with a different image digest if user wants to operate only on a subset of the original multi-platform image. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
c8d-multiplatform-convert
branch
from
May 20, 2024 15:50
a096594
to
f616114
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
ImageConvert
operation to the image service (only supported by the containerd image store) to convert multi-platform image indexes.The intent behind adding a new operation is to make the reduction of a multi-platform image to a single-platform image explicit to the user and not force operation like push to create a new image index with a different image digest if user wants to operate only on a subset of the original multi-platform image.
- How to verify it
TestImageConvert
unit test.Manual test with docker/cli#4983:
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)