Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EpochsTFR.add_channels() #12616

Merged
merged 5 commits into from
May 21, 2024

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented May 17, 2024

EpochsTFR.add_channels() is currently broken, since it adds the objects in the wrong dimension (0, but should be 1). I think this should be backported if possible.

@cbrnr cbrnr added BUG backport-candidate on-merge: backport to maint/1.7 labels May 17, 2024
@cbrnr cbrnr force-pushed the fix-epochstfr-add-channels branch from 3786fda to 81ce0ad Compare May 17, 2024 06:00
@cbrnr cbrnr requested a review from adam2392 as a code owner May 17, 2024 08:05
Co-authored-by: Richard Höchenberger <richard.hoechenberger@gmail.com>
@hoechenberger hoechenberger merged commit 4c9a176 into mne-tools:main May 21, 2024
30 checks passed
@hoechenberger
Copy link
Member

Thanks @cbrnr !

@cbrnr cbrnr deleted the fix-epochstfr-add-channels branch May 21, 2024 11:16
@drammock
Copy link
Member

@cbrnr or @hoechenberger can you backport?

@cbrnr cbrnr mentioned this pull request May 21, 2024
@cbrnr
Copy link
Contributor Author

cbrnr commented May 21, 2024

Sorry, I don't really have time to go through this process, but please see #12623.

@drammock
Copy link
Member

@meeseeksdev backport to maint/1.7

@larsoner
Copy link
Member

@drammock the next time we want to backport we should try using the backport-candidate label -- I added some text to the description field of the label that should make the bot auto-open a PR to backport the change once the PR is merged.

@larsoner
Copy link
Member

(Though I see it was too late here since this was merged a while ago!)

@drammock
Copy link
Member

(Though I see it was too late here since this was merged a while ago!)

...and already had that label :) though I guess I could have tried removing and re-adding the label, is that expected to work?

regardless: this was the backport candidate that spurred the discussion that led to trying the bot, so I wanted to get it open quickly before I forgot about it (again)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate on-merge: backport to maint/1.7 BUG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants