Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try fixed-width social icons on website #12565

Merged
merged 6 commits into from
Apr 23, 2024
Merged

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Apr 23, 2024

This fixes the width of all social icons to 25px (previously, only the Discord icon was 25px wide, whereas the other icons were 18px wide). I'm also removing the Twitter (X) social icon to increase horizontal space in the navbar. Finally, I've moved the GitHub logo all the way to the right to make it stand out more.

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 23, 2024

@drammock I'd like to have the search button instead of the search field. According to the docs, this should be the default, and we're not changing it anywhere (at least as far as I can see). What do I need to do (including search-button.html didn't work as you've suggested here).

@drammock
Copy link
Member

@drammock I'd like to have the search button instead of the search field. According to the docs, this should be the default

The docs are wrong about the default, it seems. Default is the "button that looks like a field and shows the shortcut" AKA the "search field".

What do I need to do (including search-button.html didn't work as you've suggested here).

It did work in the sense that now on the PR build you have both the search pseudo-field and also the standalone magnifying glass. But where it should go is not navbar_end but rather navbar_persistent (so that it still shows up on mobile devices). The theme docs section configure the search field position says as much.

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 23, 2024

While I'm at it, does anyone have a suggestion for nicer secondary(?) colors (when you hover over links and the search box outline)? Currently, it's violet/purple in both light and dark themes. We could use colors from our Discourse website (#3369FF for light and #759AFF for dark), WDYT?

@drammock
Copy link
Member

While I'm at it, does anyone have a suggestion for nicer secondary(?) colors (when you hover over links and the search box outline)? Currently, it's violet/purple in both light and dark themes. We could use colors from our Discourse website (#3369FF for light and #759AFF for dark), WDYT?

Cf. #12228 (comment) lot of accessibility expertise went into creating the theme's color palette. I'm definitely open to some customization to make it more distinct / MNE-branded, but not at the expense of the a11y guidelines. Can you open a new issue to specifically discuss overrides to the theme's color palette?

@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 23, 2024

OK, this is ready, let's discuss color palette changes and other things mentioned in #12558 in separate issues/PRs.

@drammock drammock enabled auto-merge (squash) April 23, 2024 15:11
@drammock drammock merged commit 9262ae4 into mne-tools:main Apr 23, 2024
30 checks passed
@hoechenberger
Copy link
Member

Cf. #12228 (comment) lot of accessibility expertise went into creating the theme's color palette. I'm definitely open to some customization to make it more distinct / MNE-branded, but not at the expense of the a11y guidelines.

+1 on this! 👍

@cbrnr cbrnr deleted the website branch April 24, 2024 05:09
@cbrnr
Copy link
Contributor Author

cbrnr commented Apr 24, 2024

Quick question, when will these changes be visible on the dev version of mne.tools? Is there some cron job which regularly updates it, or are changes pushed/pulled and I forgot to do that here?

@drammock
Copy link
Member

There's a daily cron job that runs "overnight" w.r.t. the time zones of most of our devs (I forget exactly when)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants