Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Pupil Deconvolution (port from pyeparse) #12505

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Feature: Pupil Deconvolution (port from pyeparse) #12505

wants to merge 8 commits into from
+363 −6

Commits on Mar 18, 2024

  1. Add author name Hoeks to ignore_words

    @scott-huberty
    scott-huberty committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    538bfb1 View commit details
    Browse the repository at this point in the history

  2. ENH: add pupil deconvolution method, ported from pyeparse 

    This basically ports the code from pyeparse, with slight updates to work with mne and match mne and modern python conventions.
    @scott-huberty
    scott-huberty committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    8d5d749 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Apply suggestions from code review [ci skip] 

    From Mathieu and Eric

Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
    @scott-huberty @mscheltienne @larsoner
    3 people committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    7a09a38 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    693fa08 View commit details
    Browse the repository at this point in the history

  3. FIX: nest import of BaseEpochs 

    Was causing a circular import error in https://github.com/mne-tools/mne-python/actions/runs/8347127725/job/22846082215?pr=12505
    @scott-huberty
    scott-huberty committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    029afca View commit details
    Browse the repository at this point in the history

  4. DOC: update changelog

    @scott-huberty
    scott-huberty committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    0c54803 View commit details
    Browse the repository at this point in the history

  5. Apply remaining suggestions from Mathieu 

    Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
    @scott-huberty @mscheltienne
    scott-huberty and mscheltienne committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    6b2ea46 View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2024

  1. FIX, DOC: add n_fit_times to xref_ignore

    @scott-huberty
    scott-huberty committed Mar 20, 2024
    Configuration menu
    Copy the full SHA
    8a8cecb View commit details
    Browse the repository at this point in the history