New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: blink annotations eyetracking/pupilometry #12415
base: main
Are you sure you want to change the base?
Conversation
alter interpolation function to account for first sample of the raw signal - which allows you to account for if a raw object has been cropped to accurately interpolate the correct periods of data
import required annotations function properly
for more information, see https://pre-commit.ci
@scott-huberty @larsoner sorry if i have completely screwed up how you guys normally do this - i closed the previous PR (i dont think i could edit the code once the PR was made) as i noticed it didn't import the annotations function needed (i incorrectly assumed it would be there by default, but then tested and found i was wrong). This should work! Again, sorry if i have messed up the normal workflow 😆 |
@schekroud you can just edit the code in your |
No worries @schekroud there can be a learning curve for PR's. Have you read the contributing guide? I still use it from time to time to remind myself. One comment (@larsoner can correct me if it isn't a big deal in this case), usually it's best to open a PR from a development branch (not your main branch). This should be covered in the contributing guide (let us know if it isn't). |
I just took a closer look at this PR. It looks like most of the failing tests are unrelated, and I think all of them should have been fixed by recently merged PR's (i.e. #12417 ). @schekroud if you do want to work on this PR from a development branch here is what I would do: git commands(Assuming you are in the mne-python github respoitory directory, and on your main branch):
Then you could open another PR and close this one. resetting your main branch to be in line with mne-pythons main branchif you create a new branch with the changes from this PR, you'll want to reset your main branch:
Either way (you create a new dev branch or just continue this PR from your main branch), There a couple things to do.
|
Hi @schekroud do you still have time to work on this? I think you just need to merge in the updates to mne since your last commit, and add an entry to the changelog (see point 1 in my previous message). Let me know if you need any support from us! |
I merged main. A test should be added to cover the previous failure. |
Reference issue
Fixes #12408
What does this implement/fix?
properly adjusts blink onsets/offsets to account for the start time of the signal. This allows you to crop the signal and still have an accurate description of blink onsets