Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for dictionary-type ref_channels in set_eeg_reference() #12366

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

Add support for dictionary-type ref_channels in set_eeg_reference() #12366

wants to merge 30 commits into from
+177 −2

Commits on Jan 16, 2024

  1. init the PR draft

    @qian-chu
    qian-chu committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    1bce965 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into dict_ref

    @qian-chu
    qian-chu committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f42d5fb View commit details
    Browse the repository at this point in the history

  3. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    278fdf3 View commit details
    Browse the repository at this point in the history

  4. Create 12366.newfeature.rst

    @qian-chu
    qian-chu committed Jan 16, 2024
    Configuration menu
    Copy the full SHA
    f3cff5a View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Update 12366.newfeature.rst

    @qian-chu
    qian-chu committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    b7b5c0c View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. Merge branch 'mne-tools:main' into dict_ref

    @qian-chu
    qian-chu committed May 2, 2024
    Configuration menu
    Copy the full SHA
    7ece510 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Add custom reference based on dict 

    The current implementation is based on a dictionary mapping a list to each channel. The list contains the channels to average and take as reference for the respective channel.
I have also implemented an assertion to make sure that the channels in the dict correspond to the channels in the instance.
We might want to implement something about bad channels. If bad channels are present in the mapping, they should probably be skipped
    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    8d4516d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 3, 2024
    Configuration menu
    Copy the full SHA
    42f45b8 View commit details
    Browse the repository at this point in the history

  3. BF: use isintance to check if dict

    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    95a1434 View commit details
    Browse the repository at this point in the history

  4. BF: remove extra copy of data

    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c921d69 View commit details
    Browse the repository at this point in the history

  5. Add custom reference

    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b0c91d2 View commit details
    Browse the repository at this point in the history

  6. change doc (add Alex)

    Qian Chu committed May 3, 2024
    Configuration menu
    Copy the full SHA
    78a5c7e View commit details
    Browse the repository at this point in the history

  7. Add warning if bad channels in re-referencing scheme

    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ca6908c View commit details
    Browse the repository at this point in the history

  8. Merge branch 'dict_ref' of https://github.com/qian-chu/mne-python int… 

    …o dict_ref
    Alex Lepauvre committed May 3, 2024
    Configuration menu
    Copy the full SHA
    6ac7bed View commit details
    Browse the repository at this point in the history

  9. add _check_before_dict_reference and enrich set_eeg_reference_see_als… 

    …o_notes
    @qian-chu
    qian-chu committed May 3, 2024
    Configuration menu
    Copy the full SHA
    b1165b9 View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ed56c97 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Update reference.py

    @qian-chu
    qian-chu committed May 31, 2024
    Configuration menu
    Copy the full SHA
    d27ce12 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed May 31, 2024
    Configuration menu
    Copy the full SHA
    073ca9d View commit details
    Browse the repository at this point in the history

  3. Update test_reference.py

    @qian-chu
    qian-chu committed May 31, 2024
    Configuration menu
    Copy the full SHA
    8d744ca View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Update reference.py

    @qian-chu
    qian-chu committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    9e9507d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    24d16a5 View commit details
    Browse the repository at this point in the history

  3. Update test_reference.py

    @qian-chu
    qian-chu committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    2a6db40 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6699de0 View commit details
    Browse the repository at this point in the history

  5. formatting

    @qian-chu
    qian-chu committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    8a5232a View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    73ad30d View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2024

  1. dict does not accept repeated keys, no need to test

    @qian-chu
    qian-chu committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    3474370 View commit details
    Browse the repository at this point in the history

  2. add test for warnings and raises

    @qian-chu
    qian-chu committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    cd213ee View commit details
    Browse the repository at this point in the history

  3. Update test_reference.py

    @qian-chu
    qian-chu committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    6c79a60 View commit details
    Browse the repository at this point in the history

  4. Update docs.py

    @qian-chu
    qian-chu committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    e36ddd2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'mne-tools:main' into dict_ref

    @qian-chu
    qian-chu committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    41893f3 View commit details
    Browse the repository at this point in the history