Fix mmozuras/poper#15 (Pin rugged version to 0.23.X) #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem:
#15
The test suite currently fails because of incompatibilities in version
0.99.0
of therugged
dependency. The dependency should be pinned to an older version to ensure compatibility.The approach:
Currently, the gemspec uses ~> to set the version of the
rugged
dependency above0.23
.This operator actually allows the final sequence of digits in the version string to increment to whatever is the most recent minor version release. In this case,
0.99.0
is the most recent version ofrugged
, so the23
gets incremented to99
duringbundle install
.Adding an additional sub-version to the version string allows only the final
0
to be incremented. In this case, the most recentrugged 0.23.X
sub-version is0.23.3
, which is compatible withpoper
and will allow the test suite to pass.