Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mmozuras/poper#15 (Pin rugged version to 0.23.X) #16

Closed
wants to merge 1 commit into from

Conversation

ulyssesrex
Copy link

@ulyssesrex ulyssesrex commented Aug 12, 2020

The problem:

#15

The test suite currently fails because of incompatibilities in version 0.99.0 of the rugged dependency. The dependency should be pinned to an older version to ensure compatibility.

The approach:

Currently, the gemspec uses ~> to set the version of the rugged dependency above 0.23.

This operator actually allows the final sequence of digits in the version string to increment to whatever is the most recent minor version release. In this case, 0.99.0 is the most recent version of rugged, so the 23 gets incremented to 99 during bundle install.

Adding an additional sub-version to the version string allows only the final 0 to be incremented. In this case, the most recent rugged 0.23.X sub-version is 0.23.3, which is compatible with poper and will allow the test suite to pass.

@ulyssesrex ulyssesrex changed the title Pin rugged version to 0.23.X Fix mmozuras/poper#15 (Pin rugged version to 0.23.X) Aug 12, 2020
@ulyssesrex
Copy link
Author

@mmozuras I'd be interested in your thoughts when you get a chance. Thanks!

@jbielick
Copy link

@mmozuras would you consider giving a member of our Org (Adwerx) contributor and publishing privileges?

@ulyssesrex
Copy link
Author

I'm going to close this PR for now. Let me know if there's any interest in re-opening it.

@ulyssesrex ulyssesrex closed this Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants