Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Learner): Allow for additional input checks on task #996

Closed
wants to merge 5 commits into from

Conversation

sebffischer
Copy link
Sponsor Member

@sebffischer sebffischer commented Jan 30, 2024

By adding this feature, it is possible for learner's to perform custom compatibility checks. This is e.g. needed in torch, where we have a "tensor column", where the tensor can have different shapes. To verify that the tensor shapes fits together with the neural network, we want to perform input checks before calling into train, as incompatability is a user error and should not trigger the fallback learner

  • In case this is accepted, add it do the "Extending" tutorial from mlr3extralearners.

By adding this feature, it is possible for learner's to
perform custom compatibility checks. This is e.g. needed in torch,
where we have a "tensor column", where the tensor can have
different shapes. To verify that the tensor shapes fits together
with the neural network, we want to perform input checks **before**
calling into train, as incompatability is a user error and should
not trigger the fallback learner
R/Learner.R Outdated Show resolved Hide resolved
@sebffischer
Copy link
Sponsor Member Author

We can alternatively allow for something like this, by introducing a error condition such as NoFallback that is then handled by learner_train()

@sebffischer sebffischer closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant