Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AdaBoost Regressor #3645

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Add AdaBoost Regressor #3645

wants to merge 11 commits into from

Conversation

arthiondaena
Copy link

@arthiondaena arthiondaena commented Mar 1, 2024 •
edited

closes #3598

@mlpack-bot mlpack-bot
Copy link

mlpack-bot bot commented Mar 31, 2024

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label Mar 31, 2024
@arthiondaena
Copy link
Author

@zoq can you review this when you are free?

@mlpack-bot mlpack-bot bot removed the s: stale label Apr 1, 2024
@mlpack-bot mlpack-bot
Copy link

mlpack-bot bot commented May 1, 2024

This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! 👍

@mlpack-bot mlpack-bot bot added the s: stale label May 1, 2024
@mlpack-bot mlpack-bot bot closed this May 8, 2024
@arthiondaena arthiondaena mentioned this pull request May 14, 2024
Closed
@shrit shrit reopened this May 14, 2024
@shrit shrit removed the s: stale label May 14, 2024
shrit
shrit requested changes May 15, 2024
View reviewed changes
Copy link
Member

@shrit shrit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall looks good to me, I have added a couple of comments below, feel free to resolve all of these. However, there are a couple of things that are missing, such as examples and docs. Please add an example in the mlpack/example repository, and modify the documentation accordingly to the newly added methods. The docs for Adaboost are in the docs/ directory.

src/mlpack/methods/adaboost/adaboost_regressor.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor_impl.hpp Outdated Show resolved Hide resolved
src/mlpack/methods/adaboost/adaboost_regressor_impl.hpp Outdated Show resolved Hide resolved
src/mlpack/tests/adaboost_regressor_test.cpp Show resolved Hide resolved
src/mlpack/tests/adaboost_regressor_test.cpp Show resolved Hide resolved
@shrit
Copy link
Member

shrit commented May 24, 2024

@arthiondaena are you still interested in working on this ?

@arthiondaena
Copy link
Author

@arthiondaena are you still interested in working on this ?

I am interested, but I am busy with college work at the moment. I will work on this after some time.

@arthiondaena arthiondaena requested a review from shrit June 1, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrit shrit Awaiting requested review from shrit

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
s: needs review s: unanswered s: unlabeled
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More support for tree-based regressors
2 participants
@arthiondaena @shrit