Don't bundle Development Test on macOS #14639
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes devtest from the macOS app bundle.
When devtest was originally no longer installed it caused macOS unit tests to fail, as the unit tests required devtest to be present and macOS needs the engine to be installed first to run the unit tests. So it was enabled there in CI to make the problem go away. This unfortunately made it be still be bundled with the engine on macOS as the CI artifacts are used as releases, which has probably caused some confusion for 5.8 when MTG was debundled.
This PR does, what I probably should have done originally, and disable installing devtest again between when the engine is installed for unit tests and an app bundle is packaged.
To do
This PR is a Ready for Review.
How to test
Check the resulting CI artifact in this PR, compare to the 5.8.0 one and see that devtest is no longer present.