Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't bundle Development Test on macOS #14639

Merged
merged 1 commit into from
May 15, 2024

Conversation

rollerozxa
Copy link
Member

This PR removes devtest from the macOS app bundle.

When devtest was originally no longer installed it caused macOS unit tests to fail, as the unit tests required devtest to be present and macOS needs the engine to be installed first to run the unit tests. So it was enabled there in CI to make the problem go away. This unfortunately made it be still be bundled with the engine on macOS as the CI artifacts are used as releases, which has probably caused some confusion for 5.8 when MTG was debundled.

This PR does, what I probably should have done originally, and disable installing devtest again between when the engine is installed for unit tests and an app bundle is packaged.

To do

This PR is a Ready for Review.

How to test

Check the resulting CI artifact in this PR, compare to the 5.8.0 one and see that devtest is no longer present.

image

@wsor4035 wsor4035 added the @ Build CMake, build scripts, official builds, compiler and linker errors label May 10, 2024
@sfan5
Copy link
Member

sfan5 commented May 13, 2024

as the unit tests required devtest to be present and macOS needs the engine to be installed first to run the unit tests

Was this actually a thing or was it only that you needed the bundle file structure to run anything graphical?

@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label May 13, 2024
@rollerozxa
Copy link
Member Author

Was this actually a thing or was it only that you needed the bundle file structure to run anything graphical?

I don't think it should be necessary to install it to run the unit tests, but the path code is so hairy I don't know for sure. Running a compiled RUN_IN_PLACE=0 Minetest binary on macOS when moved from bin/ to ./ relative to the source tree makes it correctly find the source tree's engine data in my VM (it does not when kept in bin/).

@sfan5 sfan5 added 1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines and removed 1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f labels May 15, 2024
@sfan5 sfan5 merged commit 5625be7 into minetest:master May 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Build CMake, build scripts, official builds, compiler and linker errors One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants