Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to Docker GitHub Actions workflow #14638

Merged
merged 6 commits into from
May 15, 2024

Conversation

AFCMS
Copy link
Contributor

@AFCMS AFCMS commented May 10, 2024

Two fixes to the Docker image workflow.

  • Fix the workflow run on tags (was untested in my first PR, my bad)
  • Do not use Docker cache for tag builds, also add a parameter to workflow_dispatch to allow building without cache

To do

This PR is Ready for Review.

How to test

Get these commits in the master branch of a Minetest fork.

Try to run the workflow with workflow_dispatch, with and without the "Use build cache" checkbox.

Push a tag to the fork, see the workflow run in the Actions tab (unlike with the current workflow).

For these runs check the parameters of the Build and push Docker image step (in the first folding section of the log), see the no-cache parameter. It should be true on tags, false on normal push, false on PRs, true or false depending of the workflow_dispatch input.

This PR fixes the build on tags, so it should probably be merged for 5.9.0 (yet the official image could be build after the release using workflow_dispatch)

@wsor4035 wsor4035 added the @ Build CMake, build scripts, official builds, compiler and linker errors label May 10, 2024
@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label May 13, 2024
Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sfan5 sfan5 added One approval ✅ ◻️ 1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f labels May 13, 2024
@sfan5 sfan5 merged commit b230428 into minetest:master May 15, 2024
4 checks passed
@AFCMS AFCMS deleted the docker_workflow_cache branch May 16, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 approval rule testing https://gist.github.com/celeron55/bf93a47442e418a629181908f68ffb0f Bugfix 🐛 PRs that fix a bug @ Build CMake, build scripts, official builds, compiler and linker errors One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants