Fixes to Docker GitHub Actions workflow #14638
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes to the Docker image workflow.
To do
This PR is Ready for Review.
How to test
Get these commits in the master branch of a Minetest fork.
Try to run the workflow with workflow_dispatch, with and without the "Use build cache" checkbox.
Push a tag to the fork, see the workflow run in the Actions tab (unlike with the current workflow).
For these runs check the parameters of the
Build and push Docker image
step (in the first folding section of the log), see theno-cache
parameter. It should be true on tags, false on normal push, false on PRs, true or false depending of the workflow_dispatch input.This PR fixes the build on tags, so it should probably be merged for 5.9.0 (yet the official image could be build after the release using workflow_dispatch)