-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some textures in lua_api.md #14583
base: master
Are you sure you want to change the base?
Update some textures in lua_api.md #14583
Conversation
Add image prefixes where still missing, make some other examples functional as well
These are just examples so they don't necessarily need to match any existing textures in e.g. Minetest Game. |
I understand, but this allows anyone who downloads minetest to try them out. Besides, other examples do use textures from the default game. |
minetest game isnt even the default anymore, nor is it packaged with minetest anymore. perhaps if we wanted to suggest good texturenames, should name the examples something like |
|
I agree that it makes sense to specify the texture naming convention in the docs, but it also makes sense for examples themselves to use concrete, widely-available textures. Using default textures in modifier examples enables (most) developers to use them verbatim in order to get a sense for the effect of those modifiers. It's not like a developer would know how to replace a template, but would be confused as to how to replace a concrete texture, right? I must say I find this pushback of yours on a trivial edit such as this peculiar. After all, I'm not the first to use default textures for examples. Unless I'm missing something, using default textures seems logical to me |
I understand why someone would have a problem with the current examples, since they seem to encourage bad practice. However, I'm not a fan of the proposed changes for the very same reason. Minetest Game has no special status anymore. Unnecessary dependencies on I think making it clear that these names are placeholders, and encouraging following naming conventions by adding a A simple ps.
This line of argumentation leads nowhere: If this edit is trivial, the push"back" is as trivially unwarranted as the push"front". |
Add the
default
image prefix where still missing, make a few other examples functional as well