Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [Backport] Mark channel checkpoint dropped prevent cp lag metrics leakage (#32454) #33198

Merged
merged 1 commit into from
May 21, 2024

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented May 20, 2024

Cherry-pick from 2.3
pr: #32454
See also #31506 #31508


…s leakage (milvus-io#32454)

Cherry-pick from 2.3
pr: milvus-io#32454
See also milvus-io#31506 milvus-io#31508

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/S Denotes a PR that changes 10-29 lines. labels May 20, 2024
@congqixia congqixia changed the title fix: [Backport] Mark channel checkpoint dropped prevent cp lag metric… fix: [Backport] Mark channel checkpoint dropped prevent cp lag metrics leakage (#32454) May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.19%. Comparing base (c35eaaa) to head (cfe62d9).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33198      +/-   ##
==========================================
+ Coverage   82.17%   82.19%   +0.02%     
==========================================
  Files        1009     1009              
  Lines      128822   128835      +13     
==========================================
+ Hits       105856   105901      +45     
+ Misses      18961    18935      -26     
+ Partials     4005     3999       -6     
Files Coverage Δ
internal/datacoord/services.go 85.72% <100.00%> (+0.01%) ⬆️
internal/datacoord/meta.go 93.96% <83.33%> (+1.36%) ⬆️

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 20, 2024
@longjiquan
Copy link
Contributor

/lgtm

sre-ci-robot pushed a commit that referenced this pull request May 21, 2024
…kage (#32454) (#33201)

Cherry-pick from master
pr: #33198
See also #31506 #31508

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot merged commit f31a20f into milvus-io:master May 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants