fix: Fix SparseFloatVector data parse error for parquet #33187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
added
dco-passed
|
@cydrain E2e jenkins job failed, comment |
|
/run-cpu-e2e |
cydrain
force-pushed
the
caiyd_fix_sparse_parse_err_for_parquet
branch
2 times, most recently
from
20caca7
to
75b9351
Compare
Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
cydrain
force-pushed
the
caiyd_fix_sparse_parse_err_for_parquet
branch
from
75b9351
to
d24a4ba
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, cydrain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33187 +/- ##
==========================================
+ Coverage 82.15% 82.19% +0.03%
==========================================
Files 1006 1009 +3
Lines 128449 128835 +386
==========================================
+ Hits 105529 105895 +366
- Misses 18939 18949 +10
- Partials 3981 3991 +10
|
cydrain
added a commit
to cydrain/milvus
that referenced
this pull request
May 27, 2024
…ilvus 2.4 milvus-io#33064 Support readable JSON file import for Float16/BFloat16/SparseFloat milvus-io#33101 Store SparseFloatVector into parquet as JSON string milvus-io#33187 Fix SparseFloatVector data parse error for parquet milvus-io#33259 Fix SparseFloatVector data parse error for json milvus-io#33224 Optimize bulk insert unittest Issue: milvus-io#22837 Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 30, 2024
…ilvus2.4 (#33391) Cherry pick from master pr: #33064 #33101 #33187 #33259 #33224 #33064 Support readable JSON file import for Float16/BFloat16/SparseFloat #33101 Store SparseFloatVector into parquet as JSON string #33187 Fix SparseFloatVector data parse error for parquet #33259 Fix SparseFloatVector data parse error for json #33224 Optimize bulk insert unittest Signed-off-by: Cai Yudong <yudong.cai@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #22837 #33162