Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support integral type for MV and skip MV if there is only one category #33161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented May 20, 2024

issue: #29892

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

@PwzXxm ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented May 20, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PwzXxm
Copy link
Contributor Author

PwzXxm commented May 21, 2024

rerun ut

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 48.27586% with 15 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (a1232fa) to head (1b14480).
Report is 7 commits behind head on master.

Current head 1b14480 differs from pull request most recent head 907c82f

Please upload reports for the commit 907c82f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33161      +/-   ##
==========================================
+ Coverage   80.88%   82.23%   +1.34%     
==========================================
  Files        1051     1000      -51     
  Lines      134863   129046    -5817     
==========================================
- Hits       109088   106121    -2967     
+ Misses      21590    18926    -2664     
+ Partials     4185     3999     -186     
Files Coverage Δ
pkg/util/typeutil/schema.go 86.03% <100.00%> (+0.25%) ⬆️
internal/core/src/storage/DiskFileManagerImpl.cpp 64.41% <46.42%> (-0.10%) ⬇️

... and 457 files with indirect coverage changes

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: PwzXxm
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Jun 11, 2024

@PwzXxm E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants