enhance: Try LatestMessageID when checkpoint unmarshal fails #33158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See also milvus-io#33122 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33158 +/- ##
=======================================
Coverage 82.18% 82.18%
=======================================
Files 1009 1009
Lines 128806 128824 +18
=======================================
+ Hits 105860 105879 +19
+ Misses 18953 18952 -1
Partials 3993 3993
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sre-ci-robot
pushed a commit
that referenced
this pull request
May 21, 2024
yanliang567
added
ci-passed
manual-pass
congqixia
added a commit
to congqixia/milvus
that referenced
this pull request
May 22, 2024
…io#33158) See also milvus-io#33122 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot
pushed a commit
that referenced
this pull request
May 23, 2024
…33123) (#33249) Cherry-pick from master pr: #33123 #33158 See also #33122 This pr add param item `mq.ignoreBadPosition` to control behavior when mq failed to parse message id from checkpoint --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com> --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also #33122