Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: access log support restful api #33155

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented May 20, 2024

relate: #31823

@aoiasd aoiasd changed the title Access log support restful api enhance: access log support restful api May 20, 2024
@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label May 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels May 20, 2024
Copy link
Contributor

mergify bot commented May 20, 2024

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd aoiasd force-pushed the C5 branch 2 times, most recently from c3b3530 to f862836 Compare May 20, 2024 09:26
Copy link
Contributor

mergify bot commented May 20, 2024

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

Copy link
Contributor

mergify bot commented May 22, 2024

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd aoiasd force-pushed the C5 branch 2 times, most recently from f450789 to 2feb40a Compare May 27, 2024 02:41
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 87.18663% with 46 lines in your changes are missing coverage. Please review.

Project coverage is 82.19%. Comparing base (e71b7c7) to head (9b3d1c7).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33155      +/-   ##
==========================================
- Coverage   82.22%   82.19%   -0.03%     
==========================================
  Files        1012     1013       +1     
  Lines      129185   129339     +154     
==========================================
+ Hits       106219   106312      +93     
- Misses      18996    19063      +67     
+ Partials     3970     3964       -6     
Files Coverage Δ
internal/distributed/proxy/httpserver/utils.go 87.89% <100.00%> (+0.12%) ⬆️
internal/distributed/proxy/service.go 84.13% <100.00%> (+0.04%) ⬆️
internal/proxy/accesslog/info/grpc_info.go 98.34% <100.00%> (+1.65%) ⬆️
internal/proxy/accesslog/util.go 61.76% <83.33%> (+11.76%) ⬆️
...nternal/distributed/proxy/httpserver/handler_v1.go 91.35% <91.20%> (+0.10%) ⬆️
...nternal/distributed/proxy/httpserver/handler_v2.go 91.56% <91.13%> (+0.20%) ⬆️
internal/proxy/accesslog/info/restful_info.go 73.80% <73.80%> (ø)

... and 42 files with indirect coverage changes

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 0cf225f into milvus-io:master May 31, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants