Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mesonbuild.meson command name #154170

Closed
wants to merge 1 commit into from
Closed

Conversation

MatejKafka
Copy link

@MatejKafka MatejKafka commented May 18, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Seems the command name is accidentally misspelled for all Meson versions.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the PullRequest-Error PR is Invalid label May 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 18, 2024
@MatejKafka
Copy link
Author

For obvious reasons, this PR affects multiple manifests. I'd very much prefer not having to open 31 PRs for this.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 18, 2024
@stephengillie
Copy link
Collaborator

Hi @MatejKafka,

Yes, as you've indicated, we have a 1 manifest change per PR policy. To proceed past this check, these changes would need to be spread out, as you've indicated a preference against performing personally.

Please consider opening an Issue instead, and coordinating with users who have automation built to submit multiple PRs.

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 20, 2024
@MatejKafka
Copy link
Author

Fine, feel free to open an issue, I don't have the time or will to bother with this.

@MatejKafka MatejKafka closed this May 20, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. Needs-Attention This work item needs to be reviewed by a member of the core team. labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PullRequest-Error PR is Invalid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants