Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for configure mixed elevation #4487

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

ryfu-msft
Copy link
Contributor

@ryfu-msft ryfu-msft commented May 15, 2024

Adds a test that runs two configuration with different elevation requirements using the dynamic runtime factory through COM.

I attempted to try different scenarios that would override the flows, but since the tests are running elevated, I wasn't able to succesfully reproduce the failures in the build machine.

Microsoft Reviewers: Open in CodeFlow

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@ryfu-msft ryfu-msft marked this pull request as ready for review May 22, 2024 18:12
@ryfu-msft ryfu-msft requested a review from a team as a code owner May 22, 2024 18:12
@ryfu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JohnMcPMS
JohnMcPMS previously approved these changes May 28, 2024
@JohnMcPMS JohnMcPMS dismissed their stale review May 28, 2024 18:34

Evaluating tests...

}

/// <summary>
/// Verifies that creating a high integrity unit processor. Must run elevated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want a test that will actually request admin. The basic test should still use the test mode, with two units (one high, one medium) and a special resource that writes the PID into a target file so that you can ensure that they were routed to different set processors.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed the tests so that it checks how many unique PIDs are created when applying an elevated and non elevated unit.

/// </summary>
[Collection("UnitTestCollection")]
[OutOfProc]
[OutOfProcOnly]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that these tests still attempt to run if you select everything in the Test Explorer? I'm not sure how to default them to not selected, but that would be better if we can.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not able to find a way to have these skipped in Test Explorer. There is an option to do something like Fact[Skip="reason"] but that causes the test to always be skipped.

@ryfu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants