Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35606
This is not finished and missing a lot of things!
Due to dawn depending on SPIRV-Tools internals, I wanted to ask what would be the best way forward?
Compiling SPIRV-Tools as part of the dawn port seems less than ideal, any suggestions?
I also currently get the following linker error when building (tried to force SPIRV-Tools to be built as static, but this doesn't help):
SPIRV-Tools-shared.lib(SPIRV-Tools-shared.dll) : error LNK2005: spvContextDestroy already defined in SPIRV-Tools.lib(table.cpp.obj)
Also about missing tint symbols, which I fixed by adding the library as a dependency. Seems like dawn is rarely built as a shared lib?
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.