Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix lock warning during ReturnResponse #17266

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix lock warning during ReturnResponse #17266

merged 1 commit into from
May 15, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented May 14, 2024

As reported here:
#16224 (comment)

The underlying WriteFile call may block indefinitely and
we shouldn't hold the terminal lock during that period.

@lhecker lhecker added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Product-Terminal The new Windows Terminal. Priority-3 A description (P3) labels May 14, 2024
@lhecker
Copy link
Member Author

lhecker commented May 14, 2024

IMO we don't need to backport this. It's not going to occur often, but it may result in small hiccups.

@lhecker lhecker mentioned this pull request May 14, 2024
Merged
@DHowett DHowett enabled auto-merge May 15, 2024 19:17
@DHowett DHowett added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 183a895 May 15, 2024
20 checks passed
@DHowett DHowett deleted the dev/lhecker/lock-fix branch May 15, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@PankajBhojwani PankajBhojwani PankajBhojwani approved these changes

Assignees
No one assigned
Labels
Area-TerminalControl Issues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.) Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lhecker @DHowett @PankajBhojwani