Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SolidColorBrush to AcrylicBrush in MainPage.xaml #17198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AlejandroBlanco2001
Copy link
Contributor

Summary of the Pull Request

In the MainPage.xaml, change the SolidColorBrush to AcrylicBrush to be able to alter the color of the panel when it cannot be rendered

References and Relevant Issues

Detailed Description of the Pull Request / Additional comments

In #12973, we changed the way of rendering the panel to use a SolidColorBrush with a transparent background. However, when this cannot be rendered, it causes an error of overlapping. Therefore, this change is to revert this panel to the original implementation introduced in #9752, using AcrylicBrush and setting the color to 'SystemChromeMediumLowColor' when it cannot be rendered.

Validation Steps Performed

  1. Open the Windows terminal App
  2. Set the width to <= 500px
  3. Open the Settings tab
  4. Check that the background is not longer overlapping.

image

PR Checklist

@AlejandroBlanco2001
Copy link
Contributor Author

@AlejandroBlanco2001 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

@carlos-zamora carlos-zamora added the Needs-Discussion Something that requires a team discussion before we can proceed label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs-Discussion Something that requires a team discussion before we can proceed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar and settings are shown at the same time
2 participants