-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: Support Bing Custom Search #6278
Merged
moonbox3
merged 9 commits into
microsoft:main
from
bochris:python_support_bing_custom_search
May 31, 2024
Merged
Python: Support Bing Custom Search #6278
moonbox3
merged 9 commits into
microsoft:main
from
bochris:python_support_bing_custom_search
May 31, 2024
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
May 15, 2024
eavanvalkenburg
approved these changes
May 16, 2024
markwallace-microsoft
added
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
documentation
memory
labels
May 16, 2024
github-actions
bot
changed the title
Python: Support Bing Custom Search
.Net: Python: Support Bing Custom Search
May 16, 2024
bochris
force-pushed
the
python_support_bing_custom_search
branch
from
May 16, 2024 22:37
ba2fdbd
to
9b0dde5
Compare
markwallace-microsoft
removed
.NET
Issue or Pull requests regarding .NET code
kernel
Issues or pull requests impacting the core kernel
documentation
memory
labels
May 16, 2024
bochris
changed the title
.Net: Python: Support Bing Custom Search
Python: Support Bing Custom Search
May 16, 2024
moonbox3
approved these changes
May 23, 2024
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
moonbox3
reviewed
May 23, 2024
python/semantic_kernel/connectors/search_engine/bing_connector.py
Outdated
Show resolved
Hide resolved
eavanvalkenburg
approved these changes
May 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 24, 2024
@bochris a change went in today to introduce a pre-commit check. Please make sure you've downloaded the |
moonbox3
approved these changes
May 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 31, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Update BingConnector to add support for Bing Custom Search, which can be used to specify domains and webpages to search and allows custom ranking adjustments.
Description
Note that API keys for Bing are separate from Bing Custom Search.
Contribution Checklist