Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Support Bing Custom Search #6278

Merged
merged 9 commits into from
May 31, 2024

Conversation

bochris
Copy link
Contributor

@bochris bochris commented May 15, 2024

Motivation and Context

Update BingConnector to add support for Bing Custom Search, which can be used to specify domains and webpages to search and allows custom ranking adjustments.

Description

Note that API keys for Bing are separate from Bing Custom Search.

Contribution Checklist

@bochris bochris requested a review from a team as a code owner May 15, 2024 23:14
@markwallace-microsoft markwallace-microsoft added the python Pull requests for the Python Semantic Kernel label May 15, 2024
@bochris bochris requested a review from a team as a code owner May 16, 2024 22:35
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation memory labels May 16, 2024
@github-actions github-actions bot changed the title Python: Support Bing Custom Search .Net: Python: Support Bing Custom Search May 16, 2024
@bochris bochris closed this May 16, 2024
@bochris bochris force-pushed the python_support_bing_custom_search branch from ba2fdbd to 9b0dde5 Compare May 16, 2024 22:37
@bochris bochris reopened this May 16, 2024
@markwallace-microsoft markwallace-microsoft removed .NET Issue or Pull requests regarding .NET code kernel Issues or pull requests impacting the core kernel documentation memory labels May 16, 2024
@bochris bochris changed the title .Net: Python: Support Bing Custom Search Python: Support Bing Custom Search May 16, 2024
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 23, 2024

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
semantic_kernel/connectors/search_engine
   bing_connector.py33330%3–76
   bing_connector_settings.py660%3–25
TOTAL609878687% 

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1403 1 💤 0 ❌ 0 🔥 23.082s ⏱️

@moonbox3 moonbox3 enabled auto-merge May 24, 2024 15:50
@moonbox3 moonbox3 added this pull request to the merge queue May 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2024
@moonbox3 moonbox3 removed the request for review from a team May 28, 2024 18:00
@moonbox3
Copy link
Contributor

@bochris a change went in today to introduce a pre-commit check. Please make sure you've downloaded the pre-commit package either from pip or via Poetry. You'll need to run the pre-commit install on the root level of the repo. Then, when you make a commit from the command line to fix this, you will see the checks run.

@moonbox3 moonbox3 added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@moonbox3 moonbox3 added this pull request to the merge queue May 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 31, 2024
@moonbox3 moonbox3 added this pull request to the merge queue May 31, 2024
Merged via the queue into microsoft:main with commit 5f40f57 May 31, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel
Projects
Status: Sprint: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants