.Net: Increase auto-invoke and in-flight tool calling hard-coded limits #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
requested review from
matthewbolanos,
SergeyMenshykh and
markwallace-microsoft
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
As we discussed offline, with auto function calling filters, someone can now put their own limits in place, so raising these to something much less likely to be hit. We could subsequently get rid of them completely if desired, but keeping them now as a backstop.
SergeyMenshykh
approved these changes
May 16, 2024
markwallace-microsoft
approved these changes
May 16, 2024
dmytrostruk
approved these changes
May 16, 2024
bochris
pushed a commit
to bochris/semantic-kernel
that referenced
this pull request
May 16, 2024
…ts (microsoft#6272) As we discussed offline yesterday, with auto function calling filters, someone can now put their own limits in place, so raising these hard-coded back stops to something much less likely to be hit. We could subsequently get rid of them completely if desired. --------- Co-authored-by: SergeyMenshykh <68852919+SergeyMenshykh@users.noreply.github.com> Co-authored-by: SergeyMenshykh <sergemenshikh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed offline yesterday, with auto function calling filters, someone can now put their own limits in place, so raising these hard-coded back stops to something much less likely to be hit. We could subsequently get rid of them completely if desired.