Java: Apply a number of fixes from API review #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
johnoliver
commented
May 14, 2024
johnoliver
commented
- Remove default chat history message, fixes Java: Chat history prepends ""Assistant is a large language model." system prompt #6222
- Allow setting deploymentName, fixes .Net: Java: In Java, it is not possible to disembiguate between model ID and deployment name #6229
- Fix some samples
Allow setting deploymentName, fixes microsoft#6229 Fix some samples
johnoliver
force-pushed
the
fixes-from-review
branch
from
d5870d0
to
0b2998a
Compare
milderhc
approved these changes
May 16, 2024
milderhc
approved these changes
May 16, 2024
dsgrieve
approved these changes
May 16, 2024
Merged
via the queue into
microsoft:java-development
with commit May 16, 2024
1f1fc97
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.