-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python: mypy coverage enhancement #6250
Merged
eavanvalkenburg
merged 16 commits into
microsoft:main
from
eavanvalkenburg:mypy_prompt_template
May 31, 2024
Merged
Python: mypy coverage enhancement #6250
eavanvalkenburg
merged 16 commits into
microsoft:main
from
eavanvalkenburg:mypy_prompt_template
May 31, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markwallace-microsoft
added
the
python
Pull requests for the Python Semantic Kernel
label
May 14, 2024
eavanvalkenburg
force-pushed
the
mypy_prompt_template
branch
from
May 14, 2024 12:27
8d3f0ca
to
08794d3
Compare
Python 3.10 Test Coverage Report •
Python 3.10 Unit Test Overview
|
moonbox3
approved these changes
May 14, 2024
This was referenced May 31, 2024
eavanvalkenburg
changed the title
Python: mypy coverage for prompt templates
Python: mypy coverage enhancement
May 31, 2024
juliomenendez
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
extend mypy coverage for prompt_templates, template_engine and some other smaller folders.
still todo: connectors, memory and planner folders.
Description
Contribution Checklist