Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Adds a memory connector for Azure Cosmos DB for NoSQL #6195

Merged
merged 31 commits into from
May 18, 2024
Merged

Python: Adds a memory connector for Azure Cosmos DB for NoSQL #6195

merged 31 commits into from
May 18, 2024

Conversation

aayush3011
Copy link
Contributor

Motivation and Context

Azure Cosmos DB is adding Vector Similarity APIs to the NoSQL project, and would like Semantic Kernel users to be able to leverage them.

This adds a Memory Connector implementation for Azure Cosmos DB's, including support for the new vector search functionality coming soon in Cosmos DB.

Description

Contribution Checklist

@markwallace-microsoft markwallace-microsoft added python Pull requests for the Python Semantic Kernel memory labels May 11, 2024
@aayush3011
Copy link
Contributor Author

Need to update the pyproject.toml and poetry.lock file once the new version is released for azure-cosmos

@aayush3011 aayush3011 marked this pull request as ready for review May 15, 2024 18:51
@aayush3011 aayush3011 requested a review from a team as a code owner May 15, 2024 18:51
@aayush3011
Copy link
Contributor Author

@moonbox3 , can you please review this PR as priority, we need this to be merged by this Friday for the Build Conference.

The python SDK will be released today EOD, and I will update the azure-cosmos dependency accordingly.

I have tested the functionality in my local, where it works correctly.

@moonbox3
Copy link
Contributor

@moonbox3 , can you please review this PR as priority, we need this to be merged by this Friday for the Build Conference.

The python SDK will be released today EOD, and I will update the azure-cosmos dependency accordingly.

I have tested the functionality in my local, where it works correctly.

@aayush3011 Yes, I will review first thing in the morning. Tagging @eavanvalkenburg if he can look during his morning, too, which is before mine.

@eavanvalkenburg
Copy link
Member

@aayush3011 you need to run poetry lock --no-update and I'll have a look at the code now

eavanvalkenburg
eavanvalkenburg requested changes May 16, 2024
View reviewed changes
Copy link
Member

@eavanvalkenburg eavanvalkenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing in the tests, but looks good otherwise, would be nice to have a sample with this as well, but that is optional!

python/tests/integration/connectors/memory/test_azure_cosmosdb_no_sql_memory_store.py Outdated Show resolved Hide resolved
@markwallace-microsoft
Copy link
Member

markwallace-microsoft commented May 16, 2024 •
edited

Py3.10 Test Coverage

Python 3.10 Test Coverage Report •
FileStmtsMissCoverMissing
TOTAL6176103683% 
report-only-changed-files is enabled. No files were changed during this commit :)

Python 3.10 Unit Test Overview

Tests Skipped Failures Errors Time
1328 1 💤 0 ❌ 0 🔥 12.043s ⏱️

@aayush3011
Copy link
Contributor Author

@moonbox3 @eavanvalkenburg Please review again, once you get a chance.

moonbox3
moonbox3 reviewed May 16, 2024
View reviewed changes
python/pyproject.toml Outdated Show resolved Hide resolved
moonbox3
moonbox3 reviewed May 17, 2024
View reviewed changes
python/pyproject.toml Outdated Show resolved Hide resolved
@moonbox3 moonbox3 enabled auto-merge May 17, 2024 19:02
@moonbox3 moonbox3 added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@eavanvalkenburg
Copy link
Member

Unfortunately the new integration tests for this integration were not updated for the new function names, please have a look @aayush3011

@moonbox3 moonbox3 enabled auto-merge May 17, 2024 22:29
auto-merge was automatically disabled May 17, 2024 22:31

Head branch was pushed to by a user without write access

@moonbox3 moonbox3 enabled auto-merge May 17, 2024 22:31
@moonbox3 moonbox3 added this pull request to the merge queue May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@moonbox3 moonbox3 added this pull request to the merge queue May 18, 2024
Merged via the queue into microsoft:main with commit ec93cb4 May 18, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eavanvalkenburg eavanvalkenburg eavanvalkenburg approved these changes

@moonbox3 moonbox3 moonbox3 approved these changes

Assignees
No one assigned
Labels
memory python Pull requests for the Python Semantic Kernel
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aayush3011 @moonbox3 @eavanvalkenburg @markwallace-microsoft