Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: Execution settings should not specify defaults for settings that the AI Service has a default for. #6225

Open
alliscode opened this issue May 13, 2024 · 0 comments
Assignees
Labels
.NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel

Comments

@alliscode
Copy link
Member

A request to OpenAI with no ExceutionSettings defined in user code results in the following request body:

{
    "messages": [{
            "content": "Can you help me tell the time in Seattle right now?",
            "role": "user"
        }
    ],
    "temperature": 1,
    "top_p": 1,
    "n": 1,
    "presence_penalty": 0,
    "frequency_penalty": 0,
    "model": "Dummy"
}

Values are specified for tmperature, top_p, n, presence_penalty, and frequency_penalty. It would be better to not specify these settings unless the SK user explicitly sets them. Currently, the defaults that we provide match those provided by OpenAI, so removing them should not result in changed behavior for customers.

Expected behavior

When a user of SK has not specified any ExecutionSettings, SK should not provide any:

{
    "messages": [{
            "content": "Can you help me tell the time in Seattle right now?",
            "role": "user"
        }
    ],
    "model": "Dummy"
}

Platform

  • OS: [e.g. Windows, Mac]
  • IDE: [e.g. Visual Studio, VS Code]
  • Language: [e.g. C#, Python]
  • Source: [e.g. NuGet package version 0.1.0, pip package version 0.1.0, main branch of repository]

Additional context
Add any other context about the problem here.

@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels May 13, 2024
@github-actions github-actions bot changed the title Execution settings should not specify defaults for settings that the AI Service has a default for. .Net: Execution settings should not specify defaults for settings that the AI Service has a default for. May 13, 2024
@github-actions github-actions bot changed the title .Net: Execution settings should not specify defaults for settings that the AI Service has a default for. Python: Execution settings should not specify defaults for settings that the AI Service has a default for. May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
.NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants