Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: default temp should be null, to match dotnet, and utilize OpenAI's default value. #6224

Closed
moonbox3 opened this issue May 13, 2024 · 1 comment
Labels
python Pull requests for the Python Semantic Kernel triage

Comments

@moonbox3
Copy link
Contributor

moonbox3 commented May 13, 2024

Describe the bug
In comparing the dotnet and python request body, we have different default temp values. Python defaults to 0.0 whereas dotnet defaults to 1, which is OpenAI's default value. https://platform.openai.com/docs/api-reference/completions/create#completions-create-temperature

Python:

{
    "messages":
    [
        {
            "role": "user",
            "content": "Can you help me tell the time in Seattle right now?"
        }
    ],
    "model": "gpt-3.5-turbo-1106",
    "frequency_penalty": 0.0,
    "logit_bias": {},
    "max_tokens": 256,
    "n": 1,
    "presence_penalty": 0.0,
    "stream": false,
    "temperature": 0.0,
    "top_p": 1.0
}

Versus .net:

{
  "messages": [
    {
      "content": "Can you help me tell the time in Seattle right now?",
      "role": "user"
    }
  ],
  "temperature": 1,
  "top_p": 1,
  "n": 1,
  "presence_penalty": 0,
  "frequency_penalty": 0,
  "model": "Dummy"
}
@markwallace-microsoft markwallace-microsoft added .NET Issue or Pull requests regarding .NET code python Pull requests for the Python Semantic Kernel triage labels May 13, 2024
@github-actions github-actions bot changed the title Python: default temp should be null, to match dotnet, and utilize OpenAI's default value. .Net: Python: default temp should be null, to match dotnet, and utilize OpenAI's default value. May 13, 2024
@github-actions github-actions bot changed the title .Net: Python: default temp should be null, to match dotnet, and utilize OpenAI's default value. Python: default temp should be null, to match dotnet, and utilize OpenAI's default value. May 13, 2024
@moonbox3 moonbox3 removed the .NET Issue or Pull requests regarding .NET code label May 13, 2024
@moonbox3
Copy link
Contributor Author

Dupe of #6225. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests for the Python Semantic Kernel triage
Projects
None yet
Development

No branches or pull requests

2 participants