Adds color animated nodes to tick-driven animations #12886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
force-pushed
the
colorNode
branch
2 times, most recently
from
20dcae8
to
ed6f60b
Compare
This change adds color animation support when `platformConfig: { useComposition: false }` is set. It unblocks usage of Animated.Color nodes with the NativeAnimated module.
… driver To avoid overcomplicating the base ValueAnimatedNode, this change uses memcpy to stuff the interpolated color value into the double `value` field in the ValueAnimatedNode, and reads it out as a color type if the output type is set.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
This change adds color animation support when
platformConfig: { useComposition: false }is set. It unblocks usage of Animated.Color nodes with the NativeAnimated module.Testing
The text color is not animating in this video, but does work with the Paper renderer. Fabric renderers on Windows suffer a limitation where the color prop of virtual spans cannot be animated without a state update (not only synchronously updating props).
RNTester.WinAppSDK.2024-03-22.21-40-42.mp4
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow