Sorts imports and fixes modernizes types for Flyout component #12601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes a few minor adjustments to Flyout.js and FlyoutNativeComponents.js to satisfy a few stricter flow and lint checks.
| @@ -3,14 +3,13 @@ | |||
| * Licensed under the MIT License. | |||
| * @format | |||
| */ | |||
There was a problem hiding this comment.
Should this/below have an @flow strict or @flow strict-local?
jonthysell
approved these changes
Jan 17, 2024
marlenecota
approved these changes
Feb 8, 2024
|
Change is approved. Will merge when CI runs green. |
@rozele This PR is older but had signoff pending a clean CI. If you can get that running clean, seems good to go? |
chrisglein
added
the
Needs: Author Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Makes a few minor adjustments to Flyout.js and FlyoutNativeComponents.js to satisfy a few stricter flow and lint checks.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow