Use prettier-plugin-hermes-parser to match upstream settings #12599
+62
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
changed the title
rozele
force-pushed
the
prettierFix
branch
3 times, most recently
from
e45ddaa
to
0239bc3
Compare
In order to minimize the delta between platform override files in react-native-windows and upstream facebook/react-native files, switch to prettier-plugin-hermes-parser. The same change was made in facebook/react-native@dc2037c
jonthysell
approved these changes
Jan 22, 2024
| @@ -88,7 +88,7 @@ const backgroundForLevel = (level: LogLevel) => | |||
| default: 'transparent', | |||
| pressed: LogBoxStyle.getFatalDarkColor(), | |||
| }, | |||
| }[level]); | |||
| })[level]; | |||
There was a problem hiding this comment.
It looks like you need to apply this change to packages\@office-iss\react-native-win32\src\Libraries\LogBox\UI\LogBoxInspectorHeader.win32.js in order to pass linting.
marlenecota
approved these changes
Feb 9, 2024
|
Change is approved. Will merge when CI runs green. |
@rozele PR has signoff but needs a clean CI run. With that, good to go. |
chrisglein
added
the
Needs: Author Feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What
In order to minimize the delta between platform override files in react-native-windows and upstream facebook/react-native files, switch to prettier-plugin-hermes-parser. The same change was made in facebook/react-native@dc2037c
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow