Root view panel #12372
Open
Root view panel #12372
+127
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for product view manager which need to manage keyboard/touch inputs.
rozele
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RootViewPanel is useful for product view manager which need to manage keyboard/touch inputs.
Type of Change
Why
Before this change it's not possible to make a view manager in product code for XAML controls such as Popup/Flyout. This is why it's not possible to make something like FlyoutViewManager in product code as it requires TouchEventHandler/PreviewKeyboardEventHandlerOnRoot which are not exposed in the RNW ABI.
What
Created RootViewPanel class which is exposed via RNW ABI for use in product view managers.
Testing
At Meta we've used this class to create a product view manager which uses XAML Popup. In the view manager's AddView method you can add child views onto a RootViewPanel.
Changelog
Should this change be included in the release notes: no
Microsoft Reviewers: Open in CodeFlow