Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: migrate to monosize 0.6.2 #31395

Merged
merged 3 commits into from
May 21, 2024
Merged

chore: migrate to monosize 0.6.2 #31395

merged 3 commits into from
May 21, 2024

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented May 16, 2024 •
edited

Previous Behavior

bundle-size report package names are build from project folder name

New Behavior

Related Issue(s)

@github-actions github-actions bot added this to the April Project Cycle Q1 2024 milestone May 16, 2024
@Hotell Hotell mentioned this pull request May 16, 2024
Merged
2 tasks
@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024 •
edited

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 632 631 5000
Button mount 298 300 5000
Field mount 1150 1114 5000
FluentProvider mount 722 701 5000
FluentProviderWithTheme mount 77 80 10
FluentProviderWithTheme virtual-rerender 37 35 10
FluentProviderWithTheme virtual-rerender-with-unmount 70 77 10
MakeStyles mount 857 851 50000
Persona mount 1731 1694 5000
SpinButton mount 1380 1373 5000
SwatchPicker mount 1532 1550 5000

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented May 16, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024 •
edited

Perf Analysis (@fluentui/react-northstar)

⚠️ 2 potential perf regressions detected

Potential regressions comparing to master

Scenario Current PR Ticks Baseline Ticks Ratio Regression Analysis
LayoutMinimalPerf.default 203 192 1.06:1 analysis
ProviderMinimalPerf.default 203 203 1:1 analysis
Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 206 184 1.12:1
VideoMinimalPerf.default 485 435 1.11:1
LoaderMinimalPerf.default 199 185 1.08:1
SegmentMinimalPerf.default 205 189 1.08:1
CarouselMinimalPerf.default 269 251 1.07:1
ListNestedPerf.default 337 314 1.07:1
AttachmentMinimalPerf.default 84 79 1.06:1
ImageMinimalPerf.default 239 225 1.06:1
DialogMinimalPerf.default 460 437 1.05:1
DividerMinimalPerf.default 217 206 1.05:1
FlexMinimalPerf.default 161 154 1.05:1
PortalMinimalPerf.default 88 84 1.05:1
IconMinimalPerf.default 384 367 1.05:1
TableMinimalPerf.default 244 233 1.05:1
ToolbarMinimalPerf.default 546 522 1.05:1
BoxMinimalPerf.default 197 190 1.04:1
DropdownManyItemsPerf.default 393 377 1.04:1
ListWith60ListItems.default 379 365 1.04:1
RosterPerf.default 1602 1547 1.04:1
RadioGroupMinimalPerf.default 260 251 1.04:1
TextMinimalPerf.default 197 190 1.04:1
AvatarMinimalPerf.default 104 101 1.03:1
HeaderMinimalPerf.default 213 206 1.03:1
HeaderSlotsPerf.default 474 460 1.03:1
ItemLayoutMinimalPerf.default 714 691 1.03:1
ListMinimalPerf.default 311 301 1.03:1
SliderMinimalPerf.default 761 736 1.03:1
TreeWith60ListItems.default 91 88 1.03:1
ButtonSlotsPerf.default 323 318 1.02:1
EmbedMinimalPerf.default 1885 1840 1.02:1
InputMinimalPerf.default 541 533 1.02:1
TextAreaMinimalPerf.default 299 294 1.02:1
AnimationMinimalPerf.default 296 293 1.01:1
CardMinimalPerf.default 314 311 1.01:1
ChatDuplicateMessagesPerf.default 146 145 1.01:1
DropdownMinimalPerf.default 1439 1418 1.01:1
GridMinimalPerf.default 190 189 1.01:1
LabelMinimalPerf.default 223 220 1.01:1
MenuButtonMinimalPerf.default 962 953 1.01:1
ReactionMinimalPerf.default 213 211 1.01:1
SkeletonMinimalPerf.default 201 199 1.01:1
StatusMinimalPerf.default 400 395 1.01:1
ButtonOverridesMissPerf.default 635 634 1:1
MenuMinimalPerf.default 518 517 1:1
SplitButtonMinimalPerf.default 2277 2283 1:1
TableManyItemsPerf.default 1099 1101 1:1
ChatMinimalPerf.default 438 442 0.99:1
CheckboxMinimalPerf.default 1134 1142 0.99:1
DatepickerMinimalPerf.default 3493 3519 0.99:1
FormMinimalPerf.default 221 224 0.99:1
ListCommonPerf.default 368 372 0.99:1
PopupMinimalPerf.default 341 344 0.99:1
CustomToolbarPrototype.default 1448 1457 0.99:1
TooltipMinimalPerf.default 1262 1275 0.99:1
AccordionMinimalPerf.default 85 87 0.98:1
AttachmentSlotsPerf.default 634 650 0.98:1
ProviderMergeThemesPerf.default 647 664 0.97:1
RefMinimalPerf.default 104 107 0.97:1
TreeMinimalPerf.default 469 484 0.97:1
ButtonMinimalPerf.default 83 93 0.89:1
AlertMinimalPerf.default 143 162 0.88:1

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024 •
edited

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024 •
edited

📊 Bundle size report

✅ No changes found

@fabricteam
Copy link
Collaborator

fabricteam commented May 16, 2024 •
edited

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 616 622 5000
Breadcrumb mount 1667 1679 1000
Checkbox mount 1667 1729 5000
CheckboxBase mount 1487 1488 5000
ChoiceGroup mount 2953 3004 5000
ComboBox mount 704 667 1000
CommandBar mount 6475 6435 1000
ContextualMenu mount 12677 12381 1000
DefaultButton mount 789 799 5000
DetailsRow mount 2215 2162 5000
DetailsRowFast mount 2233 2221 5000
DetailsRowNoStyles mount 2001 2015 5000
Dialog mount 2719 2644 1000
DocumentCardTitle mount 217 216 1000
Dropdown mount 1992 1966 5000
FocusTrapZone mount 1184 1139 5000
FocusZone mount 1084 1065 5000
GroupedList mount 41671 41664 2
GroupedList virtual-rerender 17867 19840 2
GroupedList virtual-rerender-with-unmount 50368 50377 2
GroupedListV2 mount 220 226 2
GroupedListV2 virtual-rerender 205 212 2
GroupedListV2 virtual-rerender-with-unmount 228 230 2
IconButton mount 1114 1140 5000
Label mount 346 343 5000
Layer mount 2724 2758 5000
Link mount 398 387 5000
MenuButton mount 964 957 5000
MessageBar mount 21777 21773 5000
Nav mount 1989 2028 1000
OverflowSet mount 780 782 5000
Panel mount 1803 1790 1000
Persona mount 759 759 1000
Pivot mount 893 893 1000
PrimaryButton mount 928 925 5000
Rating mount 4729 4622 5000
SearchBox mount 941 913 5000
Shimmer mount 1856 1884 5000
Slider mount 1350 1328 5000
SpinButton mount 3091 3030 5000
Spinner mount 390 400 5000
SplitButton mount 1844 1892 5000
Stack mount 408 410 5000
StackWithIntrinsicChildren mount 848 868 5000
StackWithTextChildren mount 2658 2620 5000
SwatchColorPicker mount 6338 6339 5000
TagPicker mount 1501 1465 5000
Text mount 378 366 5000
TextField mount 939 954 5000
ThemeProvider mount 840 846 5000
ThemeProvider virtual-rerender 585 590 5000
ThemeProvider virtual-rerender-with-unmount 1286 1315 5000
Toggle mount 609 639 5000
buttonNative mount 189 191 5000

@Hotell Hotell changed the title chore: migrate to monosize 0.6 chore: migrate to monosize 0.6.1 May 17, 2024
@Hotell Hotell marked this pull request as ready for review May 17, 2024 10:25
@Hotell Hotell requested review from a team as code owners May 17, 2024 10:25
@Hotell Hotell enabled auto-merge (squash) May 17, 2024 15:50
@Hotell Hotell changed the title chore: migrate to monosize 0.6.1 chore: migrate to monosize 0.6.2 May 20, 2024
@fabricteam
Copy link
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@tudorpopams tudorpopams self-requested a review May 21, 2024 12:06
@Hotell Hotell merged commit cbe8e42 into microsoft:master May 21, 2024
22 checks passed
@Hotell Hotell deleted the deps/bump-monosize branch May 21, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@layershifter layershifter layershifter approved these changes

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees
No one assigned
Labels
Area: Build System CI
Projects
None yet
Milestone
April Project Cycle Q1 2024
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Hotell @fabricteam @layershifter @tudorpopams